Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 20703205 authored by Thomas Gleixner's avatar Thomas Gleixner Committed by Al Viro
Browse files

audit: Do not send uninitialized data for AUDIT_TTY_GET 



audit_receive_msg() sends uninitialized data for AUDIT_TTY_GET when
the task was not found.

Send reply only when task was found.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Eric Paris <eparis@redhat.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent 3c80fe4a

kernel/audit.c

+4 −2
Original line number Diff line number Diff line
@@ -884,8 +884,10 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh) 
			spin_unlock_irq(&tsk->sighand->siglock);

		}

		read_unlock(&tasklist_lock);

		audit_send_reply(NETLINK_CB(skb).pid, seq, AUDIT_TTY_GET, 0, 0,

				 &s, sizeof(s));



		if (!err)

			audit_send_reply(NETLINK_CB(skb).pid, seq,

					 AUDIT_TTY_GET, 0, 0, &s, sizeof(s));

		break;

	}

	case AUDIT_TTY_SET: {