Commit 201a52be authored May 15, 2012 by Dan Carpenter Committed by Konrad Rzeszutek Wilk May 21, 2012

hvc_xen: NULL dereference on allocation failure



If kzalloc() returns a NULL here, we pass a NULL to
xencons_disconnect_backend() which will cause an Oops.

Also I removed the __GFP_ZERO while I was at it since kzalloc() implies
__GFP_ZERO.

CC: stable@kernel.org
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

parent d79d5959

drivers/tty/hvc/hvc_xen.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -430,9 +430,9 @@ static int __devinit xencons_probe(struct xenbus_device *dev,
		if (devid == 0)
		return -ENODEV;

		info = kzalloc(sizeof(struct xencons_info), GFP_KERNEL \| __GFP_ZERO);
		info = kzalloc(sizeof(struct xencons_info), GFP_KERNEL);
		if (!info)
		goto error_nomem;
		return -ENOMEM;
		dev_set_drvdata(&dev->dev, info);
		info->xbdev = dev;
		info->vtermno = xenbus_devid_to_vtermno(devid);