Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 20078e48 authored by Ken Depro's avatar Ken Depro Committed by Greg Kroah-Hartman
Browse files

staging: unisys: Fix "else not useful after return" warning in virthba.c 



This patch fixes a warning generated during the checkpatch script that stated
"else not useful after return".  I modified the code to return a designated
status at the end of the function, and replaced the return statement in the
"else if" to set the status accordingly.

Signed-off-by: default avatarKen Depro <kenneth.depro@unisys.com>
Signed-off-by: default avatarBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1cc598c7

drivers/staging/unisys/virthba/virthba.c

+6 −3
Original line number Diff line number Diff line
@@ -1584,6 +1584,8 @@ virthba_serverdown_complete(struct work_struct *work) 
static int

virthba_serverdown(struct virtpci_dev *virtpcidev, u32 state)

{

	int stat = 1;



	struct virthba_info *virthbainfo =

	    (struct virthba_info *)((struct Scsi_Host *)virtpcidev->scsi.

				     scsihost)->hostdata;
@@ -1598,11 +1600,12 @@ virthba_serverdown(struct virtpci_dev *virtpcidev, u32 state) 
			   &virthbainfo->serverdown_completion);

	} else if (virthbainfo->serverchangingstate) {

		LOGERR("Server already processing change state message\n");

		return 0;

	} else

		stat = 0;

	} else {

		LOGERR("Server already down, but another server down message received.");

	}



	return 1;

	return stat;

}



/*****************************************************/