Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1fad0e8b authored by Josh Wu's avatar Josh Wu Committed by David Woodhouse
Browse files

mtd: atmel_nand: move the sanity check to the beginning of pmecc_enable() 



It is better to do the sanity check for the parameter before any hardware
operation.

Signed-off-by: default avatarJosh Wu <josh.wu@atmel.com>
Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
parent e09f7f99

drivers/mtd/nand/atmel_nand.c

+4 −4
Original line number Diff line number Diff line
@@ -905,15 +905,15 @@ static void pmecc_enable(struct atmel_nand_host *host, int ecc_op) 
{

	u32 val;



	pmecc_writel(host->ecc, CTRL, PMECC_CTRL_RST);

	pmecc_writel(host->ecc, CTRL, PMECC_CTRL_DISABLE);

	val = pmecc_readl_relaxed(host->ecc, CFG);



	if (ecc_op != NAND_ECC_READ && ecc_op != NAND_ECC_WRITE) {

		dev_err(host->dev, "atmel_nand: wrong pmecc operation type!");

		return;

	}



	pmecc_writel(host->ecc, CTRL, PMECC_CTRL_RST);

	pmecc_writel(host->ecc, CTRL, PMECC_CTRL_DISABLE);

	val = pmecc_readl_relaxed(host->ecc, CFG);



	if (ecc_op == NAND_ECC_READ)

		pmecc_writel(host->ecc, CFG, (val & ~PMECC_CFG_WRITE_OP)

			| PMECC_CFG_AUTO_ENABLE);