Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1f644da7 authored by Rajneesh Bhardwaj's avatar Rajneesh Bhardwaj Committed by Andy Shevchenko
Browse files

platform/x86: intel_pmc_core: Fix file permission warnings 



Symbolic permissions 'S_IRUGO' are not preferred. This patch changes the
debugfs files to use octal permissions '0644' or '0444' as needed by the
attribute.

Signed-off-by: default avatarSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: default avatarRajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 2854a0aa

drivers/platform/x86/intel_pmc_core.c

+7 −11
Original line number Diff line number Diff line
@@ -414,31 +414,27 @@ static int pmc_core_dbgfs_register(struct pmc_dev *pmcdev) 
		return -ENOMEM;



	pmcdev->dbgfs_dir = dir;

	file = debugfs_create_file("slp_s0_residency_usec", S_IFREG | S_IRUGO,

	file = debugfs_create_file("slp_s0_residency_usec", 0444,

				   dir, pmcdev, &pmc_core_dev_state);

	if (!file)

		goto err;



	file = debugfs_create_file("pch_ip_power_gating_status",

				   S_IFREG | S_IRUGO, dir, pmcdev,

				   &pmc_core_ppfear_ops);

	file = debugfs_create_file("pch_ip_power_gating_status", 0444,

				   dir, pmcdev, &pmc_core_ppfear_ops);

	if (!file)

		goto err;



	file = debugfs_create_file("mphy_core_lanes_power_gating_status",

				   S_IFREG | S_IRUGO, dir, pmcdev,

				   &pmc_core_mphy_pg_ops);

	file = debugfs_create_file("mphy_core_lanes_power_gating_status", 0444,

				   dir, pmcdev, &pmc_core_mphy_pg_ops);

	if (!file)

		goto err;



	file = debugfs_create_file("pll_status",

				   S_IFREG | S_IRUGO, dir, pmcdev,

	file = debugfs_create_file("pll_status", 0444, dir, pmcdev,

				   &pmc_core_pll_ops);

	if (!file)

		goto err;



	file = debugfs_create_file("ltr_ignore",

				   S_IFREG | S_IRUGO, dir, pmcdev,

	file = debugfs_create_file("ltr_ignore", 0644, dir, pmcdev,

				   &pmc_core_ltr_ignore_ops);



	if (!file)