Commit 1f4fe89c authored Dec 16, 2011 by Jeff Skirvin Committed by James Bottomley Feb 19, 2012

[SCSI] libsas: Remove redundant phy state notification calls.



In the case of an explicit sas_phy_enable call to disable a phy,
the LLDD provides the calls to sas_phy_disconnected and the
PHYE_LOSS_OF_SIGNAL event.

NOTE: This assumes that the lldd(s) generate the notification, which
appears to be the case, but only verfied on isci.

Signed-off-by: Jeff Skirvin <jeffrey.d.skirvin@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

parent 2a559f4b

drivers/scsi/libsas/sas_init.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -268,11 +268,8 @@ static int sas_phy_enable(struct sas_phy *phy, int enable)

		if (enable)
		ret = transport_sas_phy_reset(phy, 0);
		else {
		sas_phy_disconnected(asd_phy);
		sas_ha->notify_phy_event(asd_phy, PHYE_LOSS_OF_SIGNAL);
		else
		ret = i->dft->lldd_control_phy(asd_phy, cmd, NULL);
		}
		} else {
		struct sas_rphy *rphy = dev_to_rphy(phy->dev.parent);
		struct domain_device *ddev = sas_find_dev_by_rphy(rphy);