Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1f288094 authored by Eric Dumazet's avatar Eric Dumazet Committed by Paul E. McKenney
Browse files

rcu: Use kthread_create_on_node() 



Commit a26ac245 (move TREE_RCU from softirq to kthread) added
per-CPU kthreads.  However, kthread creation uses kthread_create(), which
can put the kthread's stack and task struct on the wrong NUMA node.
Therefore, use kthread_create_on_node() instead of kthread_create()
so that the stacks and task structs are placed on the correct NUMA node.

A similar change was carried out in commit 94dcf29a (kthread:
use kthread_create_on_node()).

Also change rcutorture's priority-boost-test kthread creation.

Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
CC: Tejun Heo <tj@kernel.org>
CC: Rusty Russell <rusty@rustcorp.com.au>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: Andi Kleen <ak@linux.intel.com>
CC: Ingo Molnar <mingo@elte.hu>
Signed-off-by: default avatarPaul E. McKenney <paulmck@linux.vnet.ibm.com>
parent a102a9ec

kernel/rcutorture.c

+3 −2
Original line number Diff line number Diff line
@@ -1280,7 +1280,8 @@ static int rcutorture_booster_init(int cpu) 
	/* Don't allow time recalculation while creating a new task. */

	mutex_lock(&boost_mutex);

	VERBOSE_PRINTK_STRING("Creating rcu_torture_boost task");

	boost_tasks[cpu] = kthread_create(rcu_torture_boost, NULL,

	boost_tasks[cpu] = kthread_create_on_node(rcu_torture_boost, NULL,

						  cpu_to_node(cpu),

						  "rcu_torture_boost");

	if (IS_ERR(boost_tasks[cpu])) {

		retval = PTR_ERR(boost_tasks[cpu]);

kernel/rcutree_plugin.h

+4 −1
Original line number Diff line number Diff line
@@ -1560,7 +1560,10 @@ static int __cpuinit rcu_spawn_one_cpu_kthread(int cpu) 
	if (!rcu_scheduler_fully_active ||

	    per_cpu(rcu_cpu_kthread_task, cpu) != NULL)

		return 0;

	t = kthread_create(rcu_cpu_kthread, (void *)(long)cpu, "rcuc%d", cpu);

	t = kthread_create_on_node(rcu_cpu_kthread,

				   (void *)(long)cpu,

				   cpu_to_node(cpu),

				   "rcuc%d", cpu);

	if (IS_ERR(t))

		return PTR_ERR(t);

	if (cpu_online(cpu))