Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ebe88d3 authored by Stephen Boyd's avatar Stephen Boyd Committed by Greg Kroah-Hartman
Browse files

usb: ulpi: Automatically set driver::owner with ulpi_driver_register() 



Let's follow other driver registration functions and
automatically set the driver's owner member to THIS_MODULE when
ulpi_driver_register() is called. This allows ulpi driver writers
to forget about this boiler plate detail and avoids common bugs
in the process.

Signed-off-by: default avatarStephen Boyd <stephen.boyd@linaro.org>
Acked-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3cc7e7b7

drivers/usb/common/ulpi.c

+3 −2
Original line number Diff line number Diff line
@@ -127,16 +127,17 @@ static struct device_type ulpi_dev_type = { 
 *

 * Registers a driver with the ULPI bus.

 */

int ulpi_register_driver(struct ulpi_driver *drv)

int __ulpi_register_driver(struct ulpi_driver *drv, struct module *module)

{

	if (!drv->probe)

		return -EINVAL;



	drv->driver.owner = module;

	drv->driver.bus = &ulpi_bus;



	return driver_register(&drv->driver);

}

EXPORT_SYMBOL_GPL(ulpi_register_driver);

EXPORT_SYMBOL_GPL(__ulpi_register_driver);



/**

 * ulpi_unregister_driver - unregister a driver with the ULPI bus

include/linux/ulpi/driver.h

+5 −1
Original line number Diff line number Diff line
@@ -47,7 +47,11 @@ struct ulpi_driver { 


#define to_ulpi_driver(d) container_of(d, struct ulpi_driver, driver)



int ulpi_register_driver(struct ulpi_driver *drv);

/*

 * use a macro to avoid include chaining to get THIS_MODULE

 */

#define ulpi_register_driver(drv) __ulpi_register_driver(drv, THIS_MODULE)

int __ulpi_register_driver(struct ulpi_driver *drv, struct module *module);

void ulpi_unregister_driver(struct ulpi_driver *drv);



#define module_ulpi_driver(__ulpi_driver) \