Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1e7c5fd2 authored by Marc Zyngier's avatar Marc Zyngier Committed by Thomas Gleixner
Browse files

genirq: percpu: allow interrupt type to be set at enable time 



As request_percpu_irq() doesn't allow for a percpu interrupt to have
its type configured (it is generally impossible to configure it on all
CPUs at once), add a 'type' argument to enable_percpu_irq().

This allows some low-level, board specific init code to be switched to
a generic API.

[ tglx: Added WARN_ON argument ]

Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
Cc: Abhijeet Dharmapurikar <adharmap@codeaurora.org>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent 31d9d9b6

include/linux/interrupt.h

+1 −1
Original line number Diff line number Diff line
@@ -223,7 +223,7 @@ extern void disable_irq_nosync(unsigned int irq); 
extern void disable_irq(unsigned int irq);

extern void disable_percpu_irq(unsigned int irq);

extern void enable_irq(unsigned int irq);

extern void enable_percpu_irq(unsigned int irq);

extern void enable_percpu_irq(unsigned int irq, unsigned int type);



/* The following three functions are for the core kernel use only. */

#ifdef CONFIG_GENERIC_HARDIRQS

kernel/irq/manage.c

+14 −1
Original line number Diff line number Diff line
@@ -1419,7 +1419,7 @@ int request_any_context_irq(unsigned int irq, irq_handler_t handler, 
}

EXPORT_SYMBOL_GPL(request_any_context_irq);



void enable_percpu_irq(unsigned int irq)

void enable_percpu_irq(unsigned int irq, unsigned int type)

{

	unsigned int cpu = smp_processor_id();

	unsigned long flags;
@@ -1428,7 +1428,20 @@ void enable_percpu_irq(unsigned int irq) 
	if (!desc)

		return;



	type &= IRQ_TYPE_SENSE_MASK;

	if (type != IRQ_TYPE_NONE) {

		int ret;



		ret = __irq_set_trigger(desc, irq, type);



		if (ret) {

			WARN(1, "failed to set type for IRQ%d\n, irq");

			goto out;

		}

	}



	irq_percpu_enable(desc, cpu);

out:

	irq_put_desc_unlock(desc, flags);

}