Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1e653acc authored by Axel Lin's avatar Axel Lin Committed by Richard Purdie
Browse files

leds: leds-ss4200: fix led_classdev_unregister twice in error handling 



In current implementation, if device_create_file failed in register_nasgpio_led,
led_classdev_unregister will be executed twice.
( in register_nasgpio_led it calls led_classdev_unregister before return and in nas_gpio_init out_err )

This patch fixes it by only unregistering those that were successfully registered in out_err.
( not including last failed register_nasgpio_led call )

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Acked-by: default avatarDave Hansen <dave@sr71.net>
Signed-off-by: default avatarRichard Purdie <rpurdie@linux.intel.com>
parent 7e1ce34f

drivers/leds/leds-ss4200.c

+1 −1
Original line number Diff line number Diff line
@@ -534,7 +534,7 @@ static int __init nas_gpio_init(void) 
	set_power_light_amber_noblink();

	return 0;

out_err:

	for (; i >= 0; i--)

	for (i--; i >= 0; i--)

		unregister_nasgpio_led(i);

	pci_unregister_driver(&nas_gpio_pci_driver);

	return ret;