Commit 1dcd8ffc authored Aug 18, 2009 by Michael Barkowski Committed by Kumar Gala Aug 25, 2009

powerpc/qe_lib: Set gpio data before changing the direction to output



This avoids having a short glitch if the desired initial value is not
the same as what was previously in the data register.

Signed-off-by: Michael Barkowski <michaelbarkowski@ruggedcom.com>
Acked-by: Anton Vorontsov <avorontsov@ru.mvista.com>
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>

parent 9b9d401b

arch/powerpc/sysdev/qe_lib/gpio.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -105,14 +105,14 @@ static int qe_gpio_dir_out(struct gpio_chip *gc, unsigned int gpio, int val)
		struct qe_gpio_chip *qe_gc = to_qe_gpio_chip(mm_gc);
		unsigned long flags;

		qe_gpio_set(gc, gpio, val);

		spin_lock_irqsave(&qe_gc->lock, flags);

		__par_io_config_pin(mm_gc->regs, gpio, QE_PIO_DIR_OUT, 0, 0, 0);

		spin_unlock_irqrestore(&qe_gc->lock, flags);

		qe_gpio_set(gc, gpio, val);

		return 0;
		}