Commit 1d51a132 authored Sep 16, 2011 by Rasesh Mody Committed by David S. Miller Sep 17, 2011

bna: Semaphore Lock Fix



Remove a BUG_ON() as it is not required.

Change the unconditional write to release a semaphore to read sem first
and then write. This will eliminate the possibility of sem getting locked
while trying to release it in case if previous sem_get operation failed.

Signed-off-by: Gurunatha Karaje <gkaraje@brocade.com>
Signed-off-by: Rasesh Mody <rmody@brocade.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ae0e1489

drivers/net/ethernet/brocade/bna/bfa_ioc.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1201,13 +1201,13 @@ bfa_nw_ioc_sem_get(void __iomem *sem_reg)
		if (!(r32 & 1))
		return true;

		BUG_ON(!(cnt < BFA_SEM_SPINCNT));
		return false;
		}

		void
		bfa_nw_ioc_sem_release(void __iomem *sem_reg)
		{
		readl(sem_reg);
		writel(1, sem_reg);
		}