Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1d024355 authored by Andrew Patterson's avatar Andrew Patterson Committed by Jesse Barnes
Browse files

PCI: use better error return values in aer_inject 



Replaced some error return values in aer_inject. Use -ENODEV when we
can't find a device and -ENOTTY when the device does not support PCIe AER.

Acked-by: default avatarHuang Ying <ying.huang@intel.com>
Signed-off-by: default avatarAndrew Patterson <andrew.patterson@hp.com>
Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
parent cc5d153a

drivers/pci/pcie/aer/aer_inject.c

+4 −4
Original line number Diff line number Diff line
@@ -326,23 +326,23 @@ static int aer_inject(struct aer_error_inj *einj) 


	dev = pci_get_domain_bus_and_slot((int)einj->domain, einj->bus, devfn);

	if (!dev)

		return -EINVAL;

		return -ENODEV;

	rpdev = pcie_find_root_port(dev);

	if (!rpdev) {

		ret = -EINVAL;

		ret = -ENOTTY;

		goto out_put;

	}



	pos_cap_err = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ERR);

	if (!pos_cap_err) {

		ret = -EIO;

		ret = -ENOTTY;

		goto out_put;

	}

	pci_read_config_dword(dev, pos_cap_err + PCI_ERR_UNCOR_SEVER, &sever);



	rp_pos_cap_err = pci_find_ext_capability(rpdev, PCI_EXT_CAP_ID_ERR);

	if (!rp_pos_cap_err) {

		ret = -EIO;

		ret = -ENOTTY;

		goto out_put;

	}