Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1cf96da2 authored by wang di's avatar wang di Committed by Greg Kroah-Hartman
Browse files

staging: lustre: lmv: remove nlink check in lmv_revalidate_slaves 



If an application attempts to remove millions of files in a
single directory it will fail. This failure was tracked down to
the nlink < 2 check in lmv_revalidate_slaves, because after
nlink reaches to maximum value of LDISKFS_LINK_MAX (65000),
the nlink broadcast back from the server will be reported as
one. The return value of 1 is not invalid so lets remove
the check.

Signed-off-by: default avatarwang di <di.wang@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6984
Reviewed-on: http://review.whamcloud.com/16490


Reviewed-by: default avatarJames Simmons <uja.ornl@yahoo.com>
Reviewed-by: default avatarJian Yu <jian.yu@intel.com>
Reviewed-by: default avatarOleg Drokin <oleg.drokin@intel.com>
Signed-off-by: default avatarJames Simmons <jsimmons@infradead.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 77759771

drivers/staging/lustre/lustre/lmv/lmv_intent.c

+1 −15
Original line number Original line Diff line number Diff line
@@ -220,21 +220,7 @@ int lmv_revalidate_slaves(struct obd_export *exp, 
			/* refresh slave from server */

			/* refresh slave from server */

			body = req_capsule_server_get(&req->rq_pill,

			body = req_capsule_server_get(&req->rq_pill,

						      &RMF_MDT_BODY);

						      &RMF_MDT_BODY);

			LASSERT(body);

			if (!body) {



			if (unlikely(body->mbo_nlink < 2)) {

				/*

				 * If this is bad stripe, most likely due

				 * to the race between close(unlink) and

				 * getattr, let's return -EONENT, so llite

				 * will revalidate the dentry see

				 * ll_inode_revalidate_fini()

				 */

				CDEBUG(D_INODE, "%s: nlink %d < 2 corrupt stripe %d "DFID":" DFID"\n",

				       obd->obd_name, body->mbo_nlink, i,

				       PFID(&lsm->lsm_md_oinfo[i].lmo_fid),

				       PFID(&lsm->lsm_md_oinfo[0].lmo_fid));



				if (it.it_lock_mode && lockh) {

				if (it.it_lock_mode && lockh) {

					ldlm_lock_decref(lockh, it.it_lock_mode);

					ldlm_lock_decref(lockh, it.it_lock_mode);

					it.it_lock_mode = 0;

					it.it_lock_mode = 0;