Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1cdda918 authored by Paolo Abeni's avatar Paolo Abeni Committed by David S. Miller
Browse files

ipv6/udp: use sticky pktinfo egress ifindex on connect() 



Currently, the egress interface index specified via IPV6_PKTINFO
is ignored by __ip6_datagram_connect(), so that RFC 3542 section 6.7
can be subverted when the user space application calls connect()
before sendmsg().
Fix it by initializing properly flowi6_oif in connect() before
performing the route lookup.

Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
Acked-by: default avatarHannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6f21c96a

net/ipv6/datagram.c

+3 −0
Original line number Diff line number Diff line
@@ -162,6 +162,9 @@ static int __ip6_datagram_connect(struct sock *sk, struct sockaddr *uaddr, int a 
	fl6.fl6_dport = inet->inet_dport;

	fl6.fl6_sport = inet->inet_sport;



	if (!fl6.flowi6_oif)

		fl6.flowi6_oif = np->sticky_pktinfo.ipi6_ifindex;



	if (!fl6.flowi6_oif && (addr_type&IPV6_ADDR_MULTICAST))

		fl6.flowi6_oif = np->mcast_oif;