BACKPORT: sched/core: Fix reset-on-fork from RT with uclamp
uclamp_fork() resets the uclamp values to their default when the
reset-on-fork flag is set. It also checks whether the task has a RT
policy, and sets its uclamp.min to 1024 accordingly. However, during
reset-on-fork, the task's policy is lowered to SCHED_NORMAL right after,
hence leading to an erroneous uclamp.min setting for the new task if it
was forked from RT.
Fix this by removing the unnecessary check on rt_task() in
uclamp_fork() as this doesn't make sense if the reset-on-fork flag is
set.
[ qperret: BACKPORT because of a conflict with the Android-specific
SUGOV_RT_MAX_FREQ sched_feat, which is equally unnecessary in this
path ]
Bug: 120440300
Fixes: 1a00d999971c ("sched/uclamp: Set default clamps for RT tasks")
Reported-by:
Chitti Babu Theegala <ctheegal@codeaurora.org>
Signed-off-by:
Quentin Perret <qperret@google.com>
Signed-off-by:
Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by:
Patrick Bellasi <patrick.bellasi@matbug.net>
Reviewed-by:
Dietmar Eggemann <dietmar.eggemann@arm.com>
Link: https://lkml.kernel.org/r/20200416085956.217587-1-qperret@google.com
(cherry picked from commit eaf5a92ebde5bca3bb2565616115bd6d579486cd)
Signed-off-by:
Quentin Perret <qperret@google.com>
Change-Id: I9a19ac5474d0508b8437e4a1d859573b4106ed08
Loading
Please register or sign in to comment