Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1c89a8e3 authored by Alexander Aring's avatar Alexander Aring Committed by David S. Miller
Browse files

ieee802154: hwsim: using right kind of iteration 



This patch fixes the error path to unsubscribe all other phy's from
current phy. The actually code using a wrong kind of list iteration may
copied from the case to unsubscribe the current phy from all other
phy's.

Cc: Stefan Schmidt <stefan@datenfreihafen.org>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Fixes: f25da51f ("ieee802154: hwsim: add replacement for fakelb")
Signed-off-by: default avatarAlexander Aring <aring@mojatatu.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ac272a3e

drivers/net/ieee802154/mac802154_hwsim.c

+3 −1
Original line number Diff line number Diff line
@@ -735,10 +735,12 @@ static int hwsim_subscribe_all_others(struct hwsim_phy *phy) 
	return 0;



me_fail:

	list_for_each_entry(phy, &hwsim_phys, list) {

	rcu_read_lock();

	list_for_each_entry_rcu(e, &phy->edges, list) {

		list_del_rcu(&e->list);

		hwsim_free_edge(e);

	}

	rcu_read_unlock();

sub_fail:

	hwsim_edge_unsubscribe_me(phy);

	return -ENOMEM;