Commit 1c755ffa authored May 05, 2016 by Dan Carpenter Committed by David S. Miller May 07, 2016

netxen: reversed condition in netxen_nic_set_link_parameters()



My static checker complains that we are using "autoneg" without
initializing it.  The problem is the ->phy_read() condition is reversed
so we only set this on error instead of success.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 545fea54

drivers/net/ethernet/qlogic/netxen/netxen_nic_hw.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1944,7 +1944,7 @@ void netxen_nic_set_link_parameters(struct netxen_adapter *adapter)
		if (adapter->phy_read &&
		adapter->phy_read(adapter,
		NETXEN_NIU_GB_MII_MGMT_ADDR_AUTONEG,
		&autoneg) != 0)
		&autoneg) == 0)
		adapter->link_autoneg = autoneg;
		} else
		goto link_down;