Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1c6969ec authored by Jan Beulich's avatar Jan Beulich Committed by Jeremy Fitzhardinge
Browse files

xen/evtchn: clear secondary CPUs' cpu_evtchn_mask[] after restore 



To bind all event channels to CPU#0, it is not sufficient to set all
of its cpu_evtchn_mask[] bits; all other CPUs also need to get their
bits cleared. Otherwise, evtchn_do_upcall() will start handling
interrupts on CPUs they're not intended to run on, which can be
particularly bad for per-CPU ones.

[ linux-2.6.18-xen.hg 7de7453dee36 ]

Signed-off-by: default avatarJan Beulich <jbeulich@novell.com>
Signed-off-by: default avatarJeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
parent 7e77506a

drivers/xen/events.c

+5 −2
Original line number Original line Diff line number Diff line
@@ -286,9 +286,9 @@ static void bind_evtchn_to_cpu(unsigned int chn, unsigned int cpu) 




static void init_evtchn_cpu_bindings(void)

static void init_evtchn_cpu_bindings(void)

{

{

	int i;

#ifdef CONFIG_SMP

#ifdef CONFIG_SMP

	struct irq_desc *desc;

	struct irq_desc *desc;

	int i;





	/* By default all event channels notify CPU#0. */

	/* By default all event channels notify CPU#0. */

	for_each_irq_desc(i, desc) {

	for_each_irq_desc(i, desc) {
@@ -296,7 +296,10 @@ static void init_evtchn_cpu_bindings(void) 
	}

	}

#endif

#endif





	memset(cpu_evtchn_mask(0), ~0, sizeof(struct cpu_evtchn_s));

	for_each_possible_cpu(i)

		memset(cpu_evtchn_mask(i),

		       (i == 0) ? ~0 : 0, sizeof(struct cpu_evtchn_s));



}

}





static inline void clear_evtchn(int port)

static inline void clear_evtchn(int port)