Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1c445a42 authored by Vinod Koul's avatar Vinod Koul Committed by Mark Brown
Browse files

ASoC: max98090: remove superflous check for 'micbias' 



In max98090_probe(), code checks for micbias being out of range. The
'micbias' variable in unsigned and checked against M98090_MBVSEL_2V2 which
is zero, so remove this check.

sound/soc/codecs/max98090.c: In function ‘max98090_probe’:
sound/soc/codecs/max98090.c:2459:2: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
  } else if (micbias < M98090_MBVSEL_2V2 || micbias > M98090_MBVSEL_2V8) {

Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent a5de5b74

sound/soc/codecs/max98090.c

+1 −1
Original line number Diff line number Diff line
@@ -2456,7 +2456,7 @@ static int max98090_probe(struct snd_soc_codec *codec) 
	if (err) {

		micbias = M98090_MBVSEL_2V8;

		dev_info(codec->dev, "use default 2.8v micbias\n");

	} else if (micbias < M98090_MBVSEL_2V2 || micbias > M98090_MBVSEL_2V8) {

	} else if (micbias > M98090_MBVSEL_2V8) {

		dev_err(codec->dev, "micbias out of range 0x%x\n", micbias);

		micbias = M98090_MBVSEL_2V8;

	}