Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1c10b4b3 authored by Christian Borntraeger's avatar Christian Borntraeger Committed by Greg Kroah-Hartman
Browse files

s390/zcrypt: Fix ZCRYPT_PERDEV_REQCNT ioctl 



commit f7e80983f0cf470bb82036e73bff4d5a7daf8fc2 upstream.

reqcnt is an u32 pointer but we do copy sizeof(reqcnt) which is the
size of the pointer. This means we only copy 8 byte. Let us copy
the full monty.

Signed-off-by: default avatarChristian Borntraeger <borntraeger@de.ibm.com>
Cc: Harald Freudenberger <freude@linux.ibm.com>
Cc: stable@vger.kernel.org
Fixes: af4a7227 ("s390/zcrypt: Support up to 256 crypto adapters.")
Reviewed-by: default avatarHarald Freudenberger <freude@linux.ibm.com>
Signed-off-by: default avatarVasily Gorbik <gor@linux.ibm.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f3e8ed3d

drivers/s390/crypto/zcrypt_api.c

+2 −1
Original line number Diff line number Diff line
@@ -915,7 +915,8 @@ static long zcrypt_unlocked_ioctl(struct file *filp, unsigned int cmd, 
		if (!reqcnt)

			return -ENOMEM;

		zcrypt_perdev_reqcnt(reqcnt, AP_DEVICES);

		if (copy_to_user((int __user *) arg, reqcnt, sizeof(reqcnt)))

		if (copy_to_user((int __user *) arg, reqcnt,

				 sizeof(u32) * AP_DEVICES))

			rc = -EFAULT;

		kfree(reqcnt);

		return rc;