Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1bddc2f5 authored by Axel Lin's avatar Axel Lin Committed by Liam Girdwood
Browse files

regulator: lp3971 - remove unnecessary ret value checking in lp3971_i2c_write() 



i2c_smbus_write_byte_data() returns zero or negative value,
therefore no need to check if ret is greater than zero or not.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Acked-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: default avatarLiam Girdwood <lrg@slimlogic.co.uk>
parent 53a4befa

drivers/regulator/lp3971.c

+1 −7
Original line number Original line Diff line number Diff line
@@ -387,15 +387,9 @@ static int lp3971_i2c_read(struct i2c_client *i2c, char reg, int count, 
static int lp3971_i2c_write(struct i2c_client *i2c, char reg, int count,

static int lp3971_i2c_write(struct i2c_client *i2c, char reg, int count,

	const u16 *src)

	const u16 *src)

{

{

	int ret;



	if (count != 1)

	if (count != 1)

		return -EIO;

		return -EIO;

	ret = i2c_smbus_write_byte_data(i2c, reg, *src);

	return i2c_smbus_write_byte_data(i2c, reg, *src);

	if (ret >= 0)

		return 0;



	return ret;

}

}





static u8 lp3971_reg_read(struct lp3971 *lp3971, u8 reg)

static u8 lp3971_reg_read(struct lp3971 *lp3971, u8 reg)