Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b9e3f85 authored by Hemant Kumar's avatar Hemant Kumar Committed by Gerrit - the friendly Code Review server
Browse files

sound: usb: Add return value to debug log 



Log handle_uaudio_stream_req() function's return value.
This helps to debug situations where error like -EPROTO
is returned silently if dynamic debug is not enabled in
usb core layer. Also clean up debug log statement.

Change-Id: I9f8821e1d32f210f9a46bdf383dcb7900d4d41bb
Signed-off-by: default avatarHemant Kumar <hemantk@codeaurora.org>
parent 1d45792c

sound/usb/usb_audio_qmi_svc.c

+4 −8
Original line number Diff line number Diff line
@@ -118,8 +118,6 @@ struct uaudio_qmi_svc { 
	struct workqueue_struct *uaudio_wq;

	struct sockaddr_qrtr client_sq;

	bool client_connected;

	ktime_t t_request_recvd;

	ktime_t t_resp_sent;

	void *uaudio_ipc_log;

};
@@ -1034,12 +1032,12 @@ static void handle_uaudio_stream_req(struct qmi_handle *handle, 
	struct uaudio_qmi_svc *svc = uaudio_svc;

	struct intf_info *info;

	struct usb_host_endpoint *ep;

	ktime_t t_request_recvd = ktime_get();



	int pcm_format;

	u8 pcm_card_num, pcm_dev_num, direction;

	int info_idx = -EINVAL, datainterval = -EINVAL, ret = 0;



	svc->t_request_recvd = ktime_get();



	uaudio_dbg("sq_node:%x sq_port:%x sq_family:%x\n", sq->sq_node,

			sq->sq_port, sq->sq_family);

	if (!svc->client_connected) {
@@ -1182,10 +1180,8 @@ static void handle_uaudio_stream_req(struct qmi_handle *handle, 
			QMI_UAUDIO_STREAM_RESP_MSG_V01_MAX_MSG_LEN,

			qmi_uaudio_stream_resp_msg_v01_ei, &resp);



	svc->t_resp_sent = ktime_get();



	uaudio_dbg("t_resp sent - t_req recvd (in ms) %lld\n",

		ktime_to_ms(ktime_sub(svc->t_resp_sent, svc->t_request_recvd)));

	uaudio_dbg("ret %d: qmi response latency %lld ms\n", ret,

		ktime_to_ms(ktime_sub(ktime_get(), t_request_recvd)));

}



static void uaudio_qmi_disconnect_work(struct work_struct *w)