Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b766291 authored by Hugo Villeneuve's avatar Hugo Villeneuve Committed by Greg Kroah-Hartman
Browse files

serial: max310x: set default value when reading clock ready bit 



commit 0419373333c2f2024966d36261fd82a453281e80 upstream.

If regmap_read() returns a non-zero value, the 'val' variable can be left
uninitialized.

Clear it before calling regmap_read() to make sure we properly detect
the clock ready bit.

Fixes: 4cf9a888 ("serial: max310x: Check the clock readiness")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarHugo Villeneuve <hvilleneuve@dimonoff.com>
Link: https://lore.kernel.org/r/20240116213001.3691629-2-hugo@hugovil.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8eed2abb

drivers/tty/serial/max310x.c

+1 −1
Original line number Diff line number Diff line
@@ -600,7 +600,7 @@ static int max310x_set_ref_clk(struct device *dev, struct max310x_port *s, 


	/* Wait for crystal */

	if (xtal) {

		unsigned int val;

		unsigned int val = 0;

		msleep(10);

		regmap_read(s->regmap, MAX310X_STS_IRQSTS_REG, &val);

		if (!(val & MAX310X_STS_CLKREADY_BIT)) {