Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1b63e376 authored by Saeed Mahameed's avatar Saeed Mahameed Committed by Greg Kroah-Hartman
Browse files

net/mlx5: EQ, Use the right place to store/read IRQ affinity hint 



[ Upstream commit 1e86ace4c140fd5a693e266c9b23409358f25381 ]

Currently the cpu affinity hint mask for completion EQs is stored and
read from the wrong place, since reading and storing is done from the
same index, there is no actual issue with that, but internal irq_info
for completion EQs stars at MLX5_EQ_VEC_COMP_BASE offset in irq_info
array, this patch changes the code to use the correct offset to store
and read the IRQ affinity hint.

Signed-off-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Reviewed-by: default avatarTariq Toukan <tariqt@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent f6d66139

drivers/net/ethernet/mellanox/mlx5/core/en_main.c

+1 −1
Original line number Diff line number Diff line
@@ -1758,7 +1758,7 @@ static void mlx5e_close_cq(struct mlx5e_cq *cq) 


static int mlx5e_get_cpu(struct mlx5e_priv *priv, int ix)

{

	return cpumask_first(priv->mdev->priv.irq_info[ix].mask);

	return cpumask_first(priv->mdev->priv.irq_info[ix + MLX5_EQ_VEC_COMP_BASE].mask);

}



static int mlx5e_open_tx_cqs(struct mlx5e_channel *c,

drivers/net/ethernet/mellanox/mlx5/core/main.c

+8 −6
Original line number Diff line number Diff line
@@ -640,18 +640,19 @@ u64 mlx5_read_internal_timer(struct mlx5_core_dev *dev) 
static int mlx5_irq_set_affinity_hint(struct mlx5_core_dev *mdev, int i)

{

	struct mlx5_priv *priv  = &mdev->priv;

	int irq = pci_irq_vector(mdev->pdev, MLX5_EQ_VEC_COMP_BASE + i);

	int vecidx = MLX5_EQ_VEC_COMP_BASE + i;

	int irq = pci_irq_vector(mdev->pdev, vecidx);



	if (!zalloc_cpumask_var(&priv->irq_info[i].mask, GFP_KERNEL)) {

	if (!zalloc_cpumask_var(&priv->irq_info[vecidx].mask, GFP_KERNEL)) {

		mlx5_core_warn(mdev, "zalloc_cpumask_var failed");

		return -ENOMEM;

	}



	cpumask_set_cpu(cpumask_local_spread(i, priv->numa_node),

			priv->irq_info[i].mask);

			priv->irq_info[vecidx].mask);



	if (IS_ENABLED(CONFIG_SMP) &&

	    irq_set_affinity_hint(irq, priv->irq_info[i].mask))

	    irq_set_affinity_hint(irq, priv->irq_info[vecidx].mask))

		mlx5_core_warn(mdev, "irq_set_affinity_hint failed, irq 0x%.4x", irq);



	return 0;
@@ -659,11 +660,12 @@ static int mlx5_irq_set_affinity_hint(struct mlx5_core_dev *mdev, int i) 


static void mlx5_irq_clear_affinity_hint(struct mlx5_core_dev *mdev, int i)

{

	int vecidx = MLX5_EQ_VEC_COMP_BASE + i;

	struct mlx5_priv *priv  = &mdev->priv;

	int irq = pci_irq_vector(mdev->pdev, MLX5_EQ_VEC_COMP_BASE + i);

	int irq = pci_irq_vector(mdev->pdev, vecidx);



	irq_set_affinity_hint(irq, NULL);

	free_cpumask_var(priv->irq_info[i].mask);

	free_cpumask_var(priv->irq_info[vecidx].mask);

}



static int mlx5_irq_set_affinity_hints(struct mlx5_core_dev *mdev)

include/linux/mlx5/driver.h

+1 −1
Original line number Diff line number Diff line
@@ -1321,7 +1321,7 @@ enum { 
static inline const struct cpumask *

mlx5_get_vector_affinity_hint(struct mlx5_core_dev *dev, int vector)

{

	return dev->priv.irq_info[vector].mask;

	return dev->priv.irq_info[vector + MLX5_EQ_VEC_COMP_BASE].mask;

}



#endif /* MLX5_DRIVER_H */