Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ae745ec authored by Wolfram Sang's avatar Wolfram Sang Committed by Greg Kroah-Hartman
Browse files

i2c: jz4780: silence log flood on txabrt 



commit 9e661cedcc0a072d91a32cb88e0515ea26e35711 upstream.

The printout for txabrt is way too talkative and is highly annoying with
scanning programs like 'i2cdetect'. Reduce it to the minimum, the rest
can be gained by I2C core debugging and datasheet information. Also,
make it a debug printout, it won't help the regular user.

Fixes: ba92222e ("i2c: jz4780: Add i2c bus controller driver for Ingenic JZ4780")
Reported-by: default avatarH. Nikolaus Schaller <hns@goldelico.com>
Tested-by: default avatarH. Nikolaus Schaller <hns@goldelico.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4bd47584

drivers/i2c/busses/i2c-jz4780.c

+2 −34
Original line number Original line Diff line number Diff line
@@ -82,25 +82,6 @@ 
#define JZ4780_I2C_STA_TFNF		BIT(1)

#define JZ4780_I2C_STA_TFNF		BIT(1)

#define JZ4780_I2C_STA_ACT		BIT(0)

#define JZ4780_I2C_STA_ACT		BIT(0)





static const char * const jz4780_i2c_abrt_src[] = {

	"ABRT_7B_ADDR_NOACK",

	"ABRT_10ADDR1_NOACK",

	"ABRT_10ADDR2_NOACK",

	"ABRT_XDATA_NOACK",

	"ABRT_GCALL_NOACK",

	"ABRT_GCALL_READ",

	"ABRT_HS_ACKD",

	"SBYTE_ACKDET",

	"ABRT_HS_NORSTRT",

	"SBYTE_NORSTRT",

	"ABRT_10B_RD_NORSTRT",

	"ABRT_MASTER_DIS",

	"ARB_LOST",

	"SLVFLUSH_TXFIFO",

	"SLV_ARBLOST",

	"SLVRD_INTX",

};



#define JZ4780_I2C_INTST_IGC		BIT(11)

#define JZ4780_I2C_INTST_IGC		BIT(11)

#define JZ4780_I2C_INTST_ISTT		BIT(10)

#define JZ4780_I2C_INTST_ISTT		BIT(10)

#define JZ4780_I2C_INTST_ISTP		BIT(9)

#define JZ4780_I2C_INTST_ISTP		BIT(9)
@@ -538,21 +519,8 @@ static irqreturn_t jz4780_i2c_irq(int irqno, void *dev_id) 




static void jz4780_i2c_txabrt(struct jz4780_i2c *i2c, int src)

static void jz4780_i2c_txabrt(struct jz4780_i2c *i2c, int src)

{

{

	int i;

	dev_dbg(&i2c->adap.dev, "txabrt: 0x%08x, cmd: %d, send: %d, recv: %d\n",



		src, i2c->cmd, i2c->cmd_buf[i2c->cmd], i2c->data_buf[i2c->cmd]);

	dev_err(&i2c->adap.dev, "txabrt: 0x%08x\n", src);

	dev_err(&i2c->adap.dev, "device addr=%x\n",

		jz4780_i2c_readw(i2c, JZ4780_I2C_TAR));

	dev_err(&i2c->adap.dev, "send cmd count:%d  %d\n",

		i2c->cmd, i2c->cmd_buf[i2c->cmd]);

	dev_err(&i2c->adap.dev, "receive data count:%d  %d\n",

		i2c->cmd, i2c->data_buf[i2c->cmd]);



	for (i = 0; i < 16; i++) {

		if (src & BIT(i))

			dev_dbg(&i2c->adap.dev, "I2C TXABRT[%d]=%s\n",

				i, jz4780_i2c_abrt_src[i]);

	}

}

}





static inline int jz4780_i2c_xfer_read(struct jz4780_i2c *i2c,

static inline int jz4780_i2c_xfer_read(struct jz4780_i2c *i2c,