Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 19c17df3 authored by Hans de Goede's avatar Hans de Goede Committed by Jani Nikula
Browse files

drm/i915/dsi: Drop bogus MIPI_SEQ_ASSERT_RESET before POWER_ON 



intel_dsi_post_disable(), which does the MIPI_SEQ_ASSERT_RESET,
will always be called at some point before intel_dsi_pre_enable()
making the MIPI_SEQ_ASSERT_RESET in intel_dsi_pre_enable() redundant.

In addition, calling MIPI_SEQ_ASSERT_RESET in the enable path goes
against the VBT spec.

Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Reviewed-by: default avatarBob Paauwe <bob.j.paauwe@intel.com>
Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1488374106-4949-3-git-send-email-jani.nikula@intel.com
parent 249f6962

drivers/gpu/drm/i915/intel_dsi.c

+0 −1
Original line number Original line Diff line number Diff line
@@ -811,7 +811,6 @@ static void intel_dsi_pre_enable(struct intel_encoder *encoder, 
	/* put device in ready state */

	/* put device in ready state */

	intel_dsi_device_ready(encoder);

	intel_dsi_device_ready(encoder);





	intel_dsi_exec_vbt_sequence(intel_dsi, MIPI_SEQ_ASSERT_RESET);

	intel_dsi_exec_vbt_sequence(intel_dsi, MIPI_SEQ_POWER_ON);

	intel_dsi_exec_vbt_sequence(intel_dsi, MIPI_SEQ_POWER_ON);

	intel_dsi_exec_vbt_sequence(intel_dsi, MIPI_SEQ_DEASSERT_RESET);

	intel_dsi_exec_vbt_sequence(intel_dsi, MIPI_SEQ_DEASSERT_RESET);

	intel_dsi_exec_vbt_sequence(intel_dsi, MIPI_SEQ_INIT_OTP);

	intel_dsi_exec_vbt_sequence(intel_dsi, MIPI_SEQ_INIT_OTP);