Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 19a07ca8 authored by Sonal Aggarwal's avatar Sonal Aggarwal
Browse files

tzlog : Add check to avoid null pointer dereferencing 



Do not assign address to structure and then do not traverse private member
 at structure without checking if its null or not. Hence, add the check to
 avoid it.

Change-Id: Ia1d38cb25ea880004954d1bfb7ed439db84abc2f
Signed-off-by: default avatarSonal Aggarwal <quic_sonaagga@quicinc.com>
parent 7d6b0435

drivers/firmware/qcom/tz_log.c

+10 −2
Original line number Diff line number Diff line 
// SPDX-License-Identifier: GPL-2.0-only

/*

 * Copyright (c) 2016-2021, The Linux Foundation. All rights reserved.

 * Copyright (c) 2022, Qualcomm Innovation Center, Inc. All rights reserved.

 */

#include <linux/debugfs.h>

#include <linux/errno.h>
@@ -1238,8 +1239,15 @@ static ssize_t tzdbgfs_read(struct file *file, char __user *buf, 
	struct seq_file *seq = file->private_data;

	int tz_id = TZDBG_STATS_MAX;



	if (seq)

	if (seq) {

		if (seq->private)

			tz_id = *(int *)(seq->private);

		else {

			pr_err("%s: Seq data private null unable to proceed\n",

				 __func__);

			return 0;

		}

	}

	else {

		pr_err("%s: Seq data null unable to proceed\n", __func__);

		return 0;