Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 198a62dd authored by Sven Eckelmann's avatar Sven Eckelmann Committed by Simon Wunderlich
Browse files

batman-adv: Fix check of retrieved orig_gw in batadv_v_gw_is_eligible 



The batadv_v_gw_is_eligible function already assumes that orig_node is not
NULL. But batadv_gw_node_get may have failed to find the originator. It
must therefore be checked whether the batadv_gw_node_get failed and not
whether orig_node is NULL to detect this error.

Fixes: 50164d8f ("batman-adv: B.A.T.M.A.N. V - implement GW selection logic")
Signed-off-by: default avatarSven Eckelmann <sven.eckelmann@openmesh.com>
Acked-by: default avatarAntonio Quartulli <a@unstable.cc>
Signed-off-by: default avatarSimon Wunderlich <sw@simonwunderlich.de>
parent fe77d825

net/batman-adv/bat_v.c

+1 −1
Original line number Diff line number Diff line
@@ -814,7 +814,7 @@ static bool batadv_v_gw_is_eligible(struct batadv_priv *bat_priv, 
	}



	orig_gw = batadv_gw_node_get(bat_priv, orig_node);

	if (!orig_node)

	if (!orig_gw)

		goto out;



	if (batadv_v_gw_throughput_get(orig_gw, &orig_throughput) < 0)