Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1967158f authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Takashi Iwai
Browse files

ALSA: x86: fix error return code in hdmi_lpe_audio_probe() 



platform_get_irq() returns an error code, but the intel_hdmi_audio
driver ignores it and always returns -ENODEV. This is not correct,
and prevents -EPROBE_DEFER from being propagated properly. Also,
notice that platform_get_irq() no longer returns 0 on error.

Print error message and propagate the return value of platform_get_irq
on failure.

Signed-off-by: default avatarGustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 0a6f0600

sound/x86/intel_hdmi_audio.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -1699,8 +1699,8 @@ static int hdmi_lpe_audio_probe(struct platform_device *pdev) 
	/* get resources */

	/* get resources */

	irq = platform_get_irq(pdev, 0);

	irq = platform_get_irq(pdev, 0);

	if (irq < 0) {

	if (irq < 0) {

		dev_err(&pdev->dev, "Could not get irq resource\n");

		dev_err(&pdev->dev, "Could not get irq resource: %d\n", irq);

		return -ENODEV;

		return irq;

	}

	}





	res_mmio = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	res_mmio = platform_get_resource(pdev, IORESOURCE_MEM, 0);