Commit 194a805d authored Apr 01, 2020 by Trond Myklebust Committed by Greg Kroah-Hartman Apr 17, 2020

NFS: Fix a page leak in nfs_destroy_unlinked_subrequests()



commit add42de31721fa29ed77a7ce388674d69f9d31a4 upstream.

When we detach a subrequest from the list, we must also release the
reference it holds to the parent.

Fixes: 5b2b5187 ("NFS: Fix nfs_page_group_destroy() and nfs_lock_and_join_requests() race cases")
Cc: stable@vger.kernel.org # v4.14+
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 83dc8f0a

fs/nfs/write.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -432,6 +432,7 @@ nfs_destroy_unlinked_subrequests(struct nfs_page *destroy_list,
		}

		subreq->wb_head = subreq;
		nfs_release_request(old_head);

		if (test_and_clear_bit(PG_INODE_REF, &subreq->wb_flags)) {
		nfs_release_request(subreq);