Commit 193d0153 authored Mar 27, 2013 by Alexey Khoroshilov Committed by Jens Axboe Mar 28, 2013

drbd: add module_put() on error path in drbd_proc_open()



If single_open() fails in drbd_proc_open(), module refcount is left incremented.
The patch adds module_put() on the error path.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Philipp Reisner <philipp.reisner@linbit.com>
Signed-off-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 607f25e5

drivers/block/drbd/drbd_proc.c

+8 −2

Original line number	Diff line number	Diff line
		@@ -313,8 +313,14 @@ static int drbd_seq_show(struct seq_file seq, void v)

		static int drbd_proc_open(struct inode inode, struct file file)
		{
		if (try_module_get(THIS_MODULE))
		return single_open(file, drbd_seq_show, PDE(inode)->data);
		int err;

		if (try_module_get(THIS_MODULE)) {
		err = single_open(file, drbd_seq_show, PDE(inode)->data);
		if (err)
		module_put(THIS_MODULE);
		return err;
		}
		return -ENODEV;
		}