Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 18cf1248 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

bna: off by one in bfa_msgq_rspq_pi_update() 



The rspq->rsphdlr[] array has BFI_MC_MAX elements, so this test was
off by one.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Acked-by: default avatarRasesh Mody <rmody@brocade.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 44861f44

drivers/net/ethernet/brocade/bna/bfa_msgq.c

+1 −1
Original line number Diff line number Diff line
@@ -483,7 +483,7 @@ bfa_msgq_rspq_pi_update(struct bfa_msgq_rspq *rspq, struct bfi_mbmsg *mb) 
		mc = msghdr->msg_class;

		num_entries = ntohs(msghdr->num_entries);



		if ((mc > BFI_MC_MAX) || (rspq->rsphdlr[mc].cbfn == NULL))

		if ((mc >= BFI_MC_MAX) || (rspq->rsphdlr[mc].cbfn == NULL))

			break;



		(rspq->rsphdlr[mc].cbfn)(rspq->rsphdlr[mc].cbarg, msghdr);