Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 186f200a authored by Michael Schmitz's avatar Michael Schmitz Committed by Geert Uytterhoeven
Browse files

input/atari: Fix atarimouse init 



Atarimouse fails to load as a module (with ENODEV), due to a brown paper
bag bug, misinterpreting the semantics of atari_keyb_init().

[geert] Propagate the return value of atari_keyb_init() everywhere

Signed-off-by: default avatarMichael Schmitz <schmitz@debian.org>
Signed-off-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
parent 7786908c

drivers/input/keyboard/atakbd.c

+3 −2
Original line number Diff line number Diff line
@@ -223,8 +223,9 @@ static int __init atakbd_init(void) 
		return -ENODEV;



	// need to init core driver if not already done so

	if (atari_keyb_init())

		return -ENODEV;

	error = atari_keyb_init();

	if (error)

		return error;



	atakbd_dev = input_allocate_device();

	if (!atakbd_dev)

drivers/input/mouse/atarimouse.c

+3 −2
Original line number Diff line number Diff line
@@ -118,8 +118,9 @@ static int __init atamouse_init(void) 
	if (!MACH_IS_ATARI || !ATARIHW_PRESENT(ST_MFP))

		return -ENODEV;



	if (!atari_keyb_init())

		return -ENODEV;

	error = atari_keyb_init();

	if (error)

		return error;



	atamouse_dev = input_allocate_device();

	if (!atamouse_dev)