Commit 1826e9b1 authored Aug 23, 2013 by Dan Carpenter Committed by Felipe Balbi Aug 27, 2013

usb: gadget: gadgetfs: use after free in dev_release()



The call to put_dev() releases "dev".  Hopefully, we don't need to set
the state to STATE_DEV_DISABLED anyway so I have removed those lines.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>

parent c078a376

drivers/usb/gadget/inode.c

+0 −4

Original line number	Original line	Diff line number	Diff line
	@@ -1270,10 +1270,6 @@ dev_release (struct inode inode, struct file fd)
	dev->buf = NULL;		dev->buf = NULL;
	put_dev (dev);		put_dev (dev);

	/* other endpoints were all decoupled from this device */
	spin_lock_irq(&dev->lock);
	dev->state = STATE_DEV_DISABLED;
	spin_unlock_irq(&dev->lock);
	return 0;		return 0;
	}		}