Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 18014fd7 authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: hda - Do zero-clear in snd_hdmi_parse_eld() itself 



Instead of doing in each caller side, snd_hdmi_parse_eld() does
zero-clear of the parsed data by itself.  This is safer and simplifies
the upcoming code changes.

Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 83266b6b

sound/pci/hda/hda_eld.c

+1 −0
Original line number Diff line number Diff line
@@ -253,6 +253,7 @@ int snd_hdmi_parse_eld(struct hda_codec *codec, struct parsed_hdmi_eld *e, 
	int mnl;

	int i;



	memset(e, 0, sizeof(*e));

	e->eld_ver = GRAB_BITS(buf, 0, 3, 5);

	if (e->eld_ver != ELD_VER_CEA_861D &&

	    e->eld_ver != ELD_VER_PARTIAL) {

sound/pci/hda/patch_hdmi.c

+0 −1
Original line number Diff line number Diff line
@@ -1570,7 +1570,6 @@ static bool hdmi_present_sense(struct hdmi_spec_per_pin *per_pin, int repoll) 
						     &eld->eld_size) < 0)

			eld->eld_valid = false;

		else {

			memset(&eld->info, 0, sizeof(struct parsed_hdmi_eld));

			if (snd_hdmi_parse_eld(codec, &eld->info, eld->eld_buffer,

						    eld->eld_size) < 0)

				eld->eld_valid = false;