Commit 17d941dc authored Jun 10, 2019 by Eric Biggers Committed by Greg Kroah-Hartman Jun 25, 2019

cfg80211: fix memory leak of wiphy device name



commit 4f488fbca2a86cc7714a128952eead92cac279ab upstream.

In wiphy_new_nm(), if an error occurs after dev_set_name() and
device_initialize() have already been called, it's necessary to call
put_device() (via wiphy_free()) to avoid a memory leak.

Reported-by:  <syzbot+7fddca22578bc67c3fe4@syzkaller.appspotmail.com>
Fixes: 1f87f7d3 ("cfg80211: add rfkill support")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 5293c79c

net/wireless/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -498,7 +498,7 @@ struct wiphy wiphy_new_nm(const struct cfg80211_ops ops, int sizeof_priv,
		&rdev->rfkill_ops, rdev);

		if (!rdev->rfkill) {
		kfree(rdev);
		wiphy_free(&rdev->wiphy);
		return NULL;
		}