Commit 179f912a authored Dec 18, 2015 by Jon Mason

NTB: ntb_process_tx error path bug



The transmit overrun avoidance error path in ntb_process_tx accidentally
swapped the first two values being passed to the tx_handler client.
This could result in crashes in the ntb_netdev (or other out-of-tree NTB
clients).

Reported-by: Alex Depoutovitch <alex@pernixdata.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>

parent afd2ff9b

drivers/ntb/ntb_transport.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1532,7 +1532,7 @@ static int ntb_process_tx(struct ntb_transport_qp *qp,

		if (entry->len > qp->tx_max_frame - sizeof(struct ntb_payload_header)) {
		if (qp->tx_handler)
		qp->tx_handler(qp->cb_data, qp, NULL, -EIO);
		qp->tx_handler(qp, qp->cb_data, NULL, -EIO);

		ntb_list_add(&qp->ntb_tx_free_q_lock, &entry->entry,
		&qp->tx_free_q);