Commit 1799ddf1 authored Nov 14, 2012 by Hante Meuleman Committed by John W. Linville Nov 16, 2012

brcmfmac: Any error should result in failure of probe.



In brcmf_sdbrcm_probe only error ELINK is seen as error. However
brcmf_bus_start can return many more error codes and all should
result in failed init of driver.

Reviewed-by: Arend Van Spriel <arend@broadcom.com>
Reviewed-by: Pieter-Paul Giesberts <pieterpg@broadcom.com>
Signed-off-by: Hante Meuleman <meuleman@broadcom.com>
Signed-off-by: Franky Lin <frankyl@broadcom.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 3e0a97e1

drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -3994,11 +3994,9 @@ void brcmf_sdbrcm_probe(u32 regsva, struct brcmf_sdio_dev sdiodev)
		/* if firmware path present try to download and bring up bus */
		ret = brcmf_bus_start(bus->sdiodev->dev);
		if (ret != 0) {
		if (ret == -ENOLINK) {
		brcmf_dbg(ERROR, "dongle is not responding\n");
		goto fail;
		}
		}

		return bus;