Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 176e4a23 authored by Rashika Kheria's avatar Rashika Kheria Committed by Brian Norris
Browse files

mtd: lpddr: Mark functions as static and remove unused function 



This patch marks the functions do_write_buffer() and do_erase_oneblock()
as static because because they are not used outside this file. It also
removes the unused function word_program() in lpddr/lpddr_cmds.c.

Thus, it also removes the following warnings in lpddr/lpddr_cmds.c:
drivers/mtd/lpddr/lpddr_cmds.c:391:5: warning: no previous prototype for ‘do_write_buffer’ [-Wmissing-prototypes]
drivers/mtd/lpddr/lpddr_cmds.c:472:5: warning: no previous prototype for ‘do_erase_oneblock’ [-Wmissing-prototypes]
drivers/mtd/lpddr/lpddr_cmds.c:751:5: warning: no previous prototype for ‘word_program’ [-Wmissing-prototypes]

Signed-off-by: default avatarRashika Kheria <rashika.kheria@gmail.com>
Reviewed-by: default avatarJosh Triplett <josh@joshtriplett.org>
Signed-off-by: default avatarBrian Norris <computersforpeace@gmail.com>
parent 5e41d0a7

drivers/mtd/lpddr/lpddr_cmds.c

+2 −30
Original line number Diff line number Diff line
@@ -388,7 +388,7 @@ static void put_chip(struct map_info *map, struct flchip *chip) 
	wake_up(&chip->wq);

}



int do_write_buffer(struct map_info *map, struct flchip *chip,

static int do_write_buffer(struct map_info *map, struct flchip *chip,

			unsigned long adr, const struct kvec **pvec,

			unsigned long *pvec_seek, int len)

{
@@ -469,7 +469,7 @@ int do_write_buffer(struct map_info *map, struct flchip *chip, 
	return ret;

}



int do_erase_oneblock(struct mtd_info *mtd, loff_t adr)

static int do_erase_oneblock(struct mtd_info *mtd, loff_t adr)

{

	struct map_info *map = mtd->priv;

	struct lpddr_private *lpddr = map->fldrv_priv;
@@ -748,34 +748,6 @@ static int lpddr_unlock(struct mtd_info *mtd, loff_t ofs, uint64_t len) 
	return do_xxlock(mtd, ofs, len, DO_XXLOCK_UNLOCK);

}



int word_program(struct map_info *map, loff_t adr, uint32_t curval)

{

    int ret;

	struct lpddr_private *lpddr = map->fldrv_priv;

	int chipnum = adr >> lpddr->chipshift;

	struct flchip *chip = &lpddr->chips[chipnum];



	mutex_lock(&chip->mutex);

	ret = get_chip(map, chip, FL_WRITING);

	if (ret) {

		mutex_unlock(&chip->mutex);

		return ret;

	}



	send_pfow_command(map, LPDDR_WORD_PROGRAM, adr, 0x00, (map_word *)&curval);



	ret = wait_for_ready(map, chip, (1<<lpddr->qinfo->SingleWordProgTime));

	if (ret)	{

		printk(KERN_WARNING"%s word_program error at: %llx; val: %x\n",

			map->name, adr, curval);

		goto out;

	}



out:	put_chip(map, chip);

	mutex_unlock(&chip->mutex);

	return ret;

}



MODULE_LICENSE("GPL");

MODULE_AUTHOR("Alexey Korolev <akorolev@infradead.org>");

MODULE_DESCRIPTION("MTD driver for LPDDR flash chips");