Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 174134ac authored by Corey Minyard's avatar Corey Minyard
Browse files

ipmi_si: Fix error handling of platform device 



Cleanup of platform devices created by the IPMI driver was not
being done correctly and could result in a memory leak.  So
create a local boolean to know how to clean up those platform
devices.

Reported-by: default avatarDavid Binderman <dcb314@hotmail.com>
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
parent 7195a5a6

drivers/char/ipmi/ipmi_si_intf.c

+6 −3
Original line number Diff line number Diff line
@@ -2045,6 +2045,7 @@ static int try_smi_init(struct smi_info *new_smi) 
	int rv = 0;

	int i;

	char *init_name = NULL;

	bool platform_device_registered = false;



	pr_info(PFX "Trying %s-specified %s state machine at %s address 0x%lx, slave address 0x%x, irq %d\n",

		ipmi_addr_src_to_str(new_smi->io.addr_source),
@@ -2173,6 +2174,7 @@ static int try_smi_init(struct smi_info *new_smi) 
				rv);

			goto out_err;

		}

		platform_device_registered = true;

	}



	dev_set_drvdata(new_smi->io.dev, new_smi);
@@ -2279,10 +2281,11 @@ static int try_smi_init(struct smi_info *new_smi) 
	}



	if (new_smi->pdev) {

		if (platform_device_registered)

			platform_device_unregister(new_smi->pdev);

		new_smi->pdev = NULL;

	} else if (new_smi->pdev) {

		else

			platform_device_put(new_smi->pdev);

		new_smi->pdev = NULL;

	}



	kfree(init_name);