Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1733fe42 authored by Oliver Neukum's avatar Oliver Neukum Committed by Greg Kroah-Hartman
Browse files

USB: serial: garmin_gps: add sanity checking for data length 



commit e9b3c610a05c1cdf8e959a6d89c38807ff758ee6 upstream.

We must not process packets shorter than a packet ID

Signed-off-by: default avatarOliver Neukum <oneukum@suse.com>
Reported-and-tested-by: default avatar <syzbot+d29e9263e13ce0b9f4fd@syzkaller.appspotmail.com>
Fixes: 1da177e4 ("Linux-2.6.12-rc2")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9a05a6f1

drivers/usb/serial/garmin_gps.c

+2 −2
Original line number Diff line number Diff line
@@ -1138,8 +1138,8 @@ static void garmin_read_process(struct garmin_data *garmin_data_p, 
		   send it directly to the tty port */

		if (garmin_data_p->flags & FLAGS_QUEUING) {

			pkt_add(garmin_data_p, data, data_length);

		} else if (bulk_data ||

			   getLayerId(data) == GARMIN_LAYERID_APPL) {

		} else if (bulk_data || (data_length >= sizeof(u32) &&

				getLayerId(data) == GARMIN_LAYERID_APPL)) {



			spin_lock_irqsave(&garmin_data_p->lock, flags);

			garmin_data_p->flags |= APP_RESP_SEEN;