Commit 156ad0d7 authored Jul 26, 2016 by Chen-Yu Tsai Committed by Maxime Ripard Aug 08, 2016

clk: sunxi-ng: Fix inverted test condition in ccu_helper_wait_for_lock



The condition passed to read*_poll_timeout() is the break condition,
i.e. wait for this condition to happen and return success.

The original code assumed the opposite, resulting in a warning when
the PLL clock rate was changed but never lost it's lock as far as
the readout indicated. This was verified by checking the read out
register value.

Fixes: 1d80c142 ("clk: sunxi-ng: Add common infrastructure")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>

parent fbe359f1

drivers/clk/sunxi-ng/ccu_common.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -31,7 +31,7 @@ void ccu_helper_wait_for_lock(struct ccu_common *common, u32 lock)
		return;

		WARN_ON(readl_relaxed_poll_timeout(common->base + common->reg, reg,
		!(reg & lock), 100, 70000));
		reg & lock, 100, 70000));
		}

		int sunxi_ccu_probe(struct device_node node, void __iomem reg,