Commit 15160f90 authored Dec 10, 2014 by Fabio Estevam Committed by Linus Torvalds Dec 10, 2014

checkpatch: improve warning message for "needless if" case



Add an 'and' to the sentence so that it looks better:

  WARNING: debugfs_remove(NULL) is safe and this check is probably not required

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 04941aa7

scripts/checkpatch.pl

+1 −1

Original line number	Diff line number	Diff line
		@@ -4446,7 +4446,7 @@ sub process {
		my $expr = '\s$\s' . quotemeta($1) . '\s$\s;';
		if ($line =~ /\b(kfree\|usb_free_urb\|debugfs_remove(?:_recursive)?)$expr/) {
		WARN('NEEDLESS_IF',
		"$1(NULL) is safe this check is probably not required\n" . $hereprev);
		"$1(NULL) is safe and this check is probably not required\n" . $hereprev);
		}
		}