Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 15081e85 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Greg Kroah-Hartman
Browse files

usbip: fix off-by-one frame number calculation 



vgadget_get_frame returns a frame number from 0 to 2046, which
may require an expensive division operation to wrap at one lower
than the usual number.

I can't see any reason for this, and all other drivers wrap at
a power-of-two number. My best explanation is that it was a simple
typo, so I'm changing the % modulo operator into a cheaper bitmask
that the other drivers use, to make it wrap after 0x7ff rather than
before it.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Reviewed-by: default avatarKrzysztof Opasiak <k.opasiak@samsung.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 12f28144

drivers/usb/usbip/vudc_dev.c

+1 −1
Original line number Diff line number Diff line
@@ -145,7 +145,7 @@ static int vgadget_get_frame(struct usb_gadget *_gadget) 
	do_gettimeofday(&now);

	return ((now.tv_sec - udc->start_time.tv_sec) * 1000 +

			(now.tv_usec - udc->start_time.tv_usec) / 1000)

			% 0x7FF;

			& 0x7FF;

}



static int vgadget_set_selfpowered(struct usb_gadget *_gadget, int value)