Commit 14e3995e authored May 16, 2017 by Wei Yongjun Committed by Stefano Stabellini May 18, 2017

xen/9pfs: fix return value check in xen_9pfs_front_probe()



In case of error, the function xenbus_read() returns ERR_PTR() and never
returns NULL. The NULL test in the return value check should be replaced
with IS_ERR().

Fixes: 71ebd719 ("xen/9pfs: connect to the backend")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>

parent 69861e0a

net/9p/trans_xen.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -454,8 +454,8 @@ static int xen_9pfs_front_probe(struct xenbus_device *dev,
		goto error_xenbus;
		}
		priv->tag = xenbus_read(xbt, dev->nodename, "tag", NULL);
		if (!priv->tag) {
		ret = -EINVAL;
		if (IS_ERR(priv->tag)) {
		ret = PTR_ERR(priv->tag);
		goto error_xenbus;
		}
		ret = xenbus_transaction_end(xbt, 0);