Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 14dbd549 authored by Sangjung Woo's avatar Sangjung Woo Committed by Chanwoo Choi
Browse files

extcon: max14577: Use devm_extcon_dev_register() 



Use the resource-managed extcon device register function (i.e.
devm_extcon_dev_register()) instead of extcon_dev_register(). If extcon device
is attached with this function, that extcon device is automatically unregistered
on driver detach. That reduces tiresome managing code.

Signed-off-by: default avatarSangjung Woo <sangjung.woo@samsung.com>
Reviewed-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
parent d92c2f12

drivers/extcon/extcon-max14577.c

+2 −7
Original line number Diff line number Diff line
@@ -747,7 +747,7 @@ static int max14577_muic_probe(struct platform_device *pdev) 


	info->edev->name = dev_name(&pdev->dev);

	info->edev->supported_cable = max14577_extcon_cable;

	ret = extcon_dev_register(info->edev);

	ret = devm_extcon_dev_register(&pdev->dev, info->edev);

	if (ret) {

		dev_err(&pdev->dev, "failed to register extcon device\n");

		return ret;
@@ -766,7 +766,7 @@ static int max14577_muic_probe(struct platform_device *pdev) 
			MAX14577_REG_DEVICEID, &id);

	if (ret < 0) {

		dev_err(&pdev->dev, "failed to read revision number\n");

		goto err_extcon;

		return ret;

	}

	dev_info(info->dev, "device ID : 0x%x\n", id);
@@ -786,10 +786,6 @@ static int max14577_muic_probe(struct platform_device *pdev) 
			delay_jiffies);



	return ret;



err_extcon:

	extcon_dev_unregister(info->edev);

	return ret;

}



static int max14577_muic_remove(struct platform_device *pdev)
@@ -797,7 +793,6 @@ static int max14577_muic_remove(struct platform_device *pdev) 
	struct max14577_muic_info *info = platform_get_drvdata(pdev);



	cancel_work_sync(&info->irq_work);

	extcon_dev_unregister(info->edev);



	return 0;

}