Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 147d88e0 authored by Dan Carpenter's avatar Dan Carpenter Committed by Steven Rostedt (VMware)
Browse files

tracing: Missing error code in tracer_alloc_buffers() 

If ring_buffer_alloc() or one of the next couple function calls fail
then we should return -ENOMEM but the current code returns success.

Link: http://lkml.kernel.org/r/20170801110201.ajdkct7vwzixahvx@mwanda



Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: stable@vger.kernel.org
Fixes: b32614c0 ('tracing/rb: Convert to hotplug state machine')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarSteven Rostedt (VMware) <rostedt@goodmis.org>
parent 4bb0f0e7

kernel/trace/trace.c

+1 −0
Original line number Diff line number Diff line
@@ -8293,6 +8293,7 @@ __init static int tracer_alloc_buffers(void) 
	if (ret < 0)

		goto out_free_cpumask;

	/* Used for event triggers */

	ret = -ENOMEM;

	temp_buffer = ring_buffer_alloc(PAGE_SIZE, RB_FL_OVERWRITE);

	if (!temp_buffer)

		goto out_rm_hp_state;