Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 141fff55 authored by Ruslan Bilovol's avatar Ruslan Bilovol Committed by Greg Kroah-Hartman
Browse files

usb: gadget: f_hid: fix endianness issue with descriptors 



[ Upstream commit 33cb46c4676d01956811b68a29157ea969a5df70 ]

Running sparse checker it shows warning message about
incorrect endianness used for descriptor initialization:

| f_hid.c:91:43: warning: incorrect type in initializer (different base types)
| f_hid.c:91:43:    expected restricted __le16 [usertype] bcdHID
| f_hid.c:91:43:    got int

Fixing issue with cpu_to_le16() macro, however this is not a real issue
as the value is the same both endians.

Cc: Fabien Chouteau <fabien.chouteau@barco.com>
Cc: Segiy Stetsyuk <serg_stetsuk@ukr.net>
Signed-off-by: default avatarRuslan Bilovol <ruslan.bilovol@gmail.com>
Link: https://lore.kernel.org/r/20210617162755.29676-1-ruslan.bilovol@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 903e2d45

drivers/usb/gadget/function/f_hid.c

+1 −1
Original line number Diff line number Diff line
@@ -88,7 +88,7 @@ static struct usb_interface_descriptor hidg_interface_desc = { 
static struct hid_descriptor hidg_desc = {

	.bLength			= sizeof hidg_desc,

	.bDescriptorType		= HID_DT_HID,

	.bcdHID				= 0x0101,

	.bcdHID				= cpu_to_le16(0x0101),

	.bCountryCode			= 0x00,

	.bNumDescriptors		= 0x1,

	/*.desc[0].bDescriptorType	= DYNAMIC */