Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 141050cf authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Lee Jones
Browse files

mfd: 88pm800: Fix I2C device resource leak if probe fails 



During probe the driver allocates two dummy I2C devices for subchips in
function pm800_pages_init(). Additionally this function allocates
regmaps for these subchips. If any of these steps fail then these dummy
I2C devices are not freed and resources leak.

On pm800_pages_init() fail the driver must call pm800_pages_exit() to
unregister dummy I2C devices.

Cc: stable@vger.kernel.org
Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 921a1b0c

drivers/mfd/88pm800.c

+1 −2
Original line number Diff line number Diff line
@@ -571,7 +571,7 @@ static int pm800_probe(struct i2c_client *client, 
	ret = pm800_pages_init(chip);

	if (ret) {

		dev_err(&client->dev, "pm800_pages_init failed!\n");

		goto err_page_init;

		goto err_device_init;

	}



	ret = device_800_init(chip, pdata);
@@ -587,7 +587,6 @@ static int pm800_probe(struct i2c_client *client, 


err_device_init:

	pm800_pages_exit(chip);

err_page_init:

err_subchip_alloc:

	pm80x_deinit();

out_init: